Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anything after a pdf or similar in iframe is not rendered #25

Closed
ahenket opened this issue May 19, 2024 · 0 comments · Fixed by #26
Closed

Anything after a pdf or similar in iframe is not rendered #25

ahenket opened this issue May 19, 2024 · 0 comments · Fixed by #26
Labels
bug Something isn't working

Comments

@ahenket
Copy link
Collaborator

ahenket commented May 19, 2024

When you have a(n inline) pdf in your CDA, this is rendered using an iframe. Below iframe nothing is rendered anymore although the footer should have been there. This is extra inconvenient when the pdf is in section that is followed by other sections.

The solution is to not write <iframe .../> but rather have a separate closing tag. To force that, you may put a space in between so <iframe ...> </iframe>. This space does not have any visual impact on the rendering other than making the following html reappear.

Reference: jekyll/jekyll#346.

@ahenket ahenket added the bug Something isn't working label May 19, 2024
ahenket added a commit that referenced this issue May 19, 2024
@ahenket ahenket linked a pull request May 19, 2024 that will close this issue
ahenket added a commit that referenced this issue May 19, 2024
ahenket added a commit that referenced this issue May 20, 2024
…-iframe-is-not-rendered

#25 Fix issue with iframe rendering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant