CDA-20047 - Update DIR schematron #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjszczep
requested changes
Aug 5, 2022
There was a problem hiding this comment.
- Why do we have the
not(@extension)requirement on CONF:1198-31206? Wouldn't a section with the right templateId and an extension still count as a DICOM Object Catalog section? - If we care enough about the DICOM template to fix its, schematron, then we should just properly turn the NPI requirement in CONF:1098-32135 into its own conformance statement in Trifolia rather than manually writing a post-hoc custom schematron test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.hl7.org/browse/CDA-20047
Makes 3 changes to DIR templates.
Also discovered that the templateId extension was incorrect - as a result the rule that required extension=2014-06-09 literally looked for a context with extension=2015-08-01 - i.e. it could never pass (unless, I suppose, if someone included BOTH extensions)