Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin react-scripts version. #70

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Pin react-scripts version. #70

merged 1 commit into from
Jun 19, 2020

Conversation

godwinpang
Copy link
Collaborator

react-scripts 3.4.1 breaks running inside docker containers.
See: facebook/create-react-app#8688

react-scripts 3.4.1 breaks running inside docker containers.
See: facebook/create-react-app#8688
@godwinpang godwinpang requested a review from a team June 19, 2020 05:34
@netlify
Copy link

netlify bot commented Jun 19, 2020

Deploy preview for hkn-portal-staging ready!

Built with commit e80966c

https://deploy-preview-70--hkn-portal-staging.netlify.app

@thai-truong
Copy link
Collaborator

Not sure if Cypress 4.8 would break or not, but 4.5 has worked consistently before, so lgtm : )

@godwinpang
Copy link
Collaborator Author

DO YOU SEE THAT GREEN CHECK

@godwinpang godwinpang merged commit 1d63fd7 into master Jun 19, 2020
@thai-truong
Copy link
Collaborator

AAAAAAAAAAAAAA ALL THE GREEN CHECKS WOOHOOOOOOOO

@godwinpang godwinpang deleted the test_circle branch June 25, 2020 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants