Create Event now works properly and as intended. #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 13, 2020 13:50
…nto dev Fixed merge conflicts.
After creating an event, the browser redirects to the newly created event's EventDetails page. Note that fbURL and canvaURL both have to either be empty or filled out with a proper URL string, otherwise a status code 400 will be sent from the backend server.
thai-truong
added
bug
|
Deploy preview for hknucsd-portal-dev ready! Built with commit d6d37f0 |
|
Okay well my git history is messed up... Guess I'll be fixing merge conflicts pretty soon |
godwinpang
requested changes
Sep 16, 2020
src/pages/App/index.tsx
Outdated
| @@ -158,4 +157,4 @@ function App(): JSX.Element { | |||
| ); | |||
| } | |||
|
|
|||
| export default config.nodeEnv === 'development' ? hot(App) : App; | |||
| export default process.env.NODE_ENV === 'development' ? hot(App) : App; | |||
There was a problem hiding this comment.
I think I messed up with merging or pulling somewhere along the line... I did not change it back myself :)))
Closed
godwinpang
pushed a commit
that referenced
this pull request
Sep 20, 2020
* Tsconfig changes again : ( * Fixed merge issue * Create Event now works properly and as intended. After creating an event, the browser redirects to the newly created event's EventDetails page. Note that fbURL and canvaURL both have to either be empty or filled out with a proper URL string, otherwise a status code 400 will be sent from the backend server. * Added url validation to create event form's schema's fbURL + canvaURL. * Changed process.env in src/index.js to using config.
thai-truong
added a commit
that referenced
this pull request
Oct 3, 2020
* Tsconfig changes again : ( * Fixed merge issue * Create Event now works properly and as intended. After creating an event, the browser redirects to the newly created event's EventDetails page. Note that fbURL and canvaURL both have to either be empty or filled out with a proper URL string, otherwise a status code 400 will be sent from the backend server. * Added url validation to create event form's schema's fbURL + canvaURL. * Changed process.env in src/index.js to using config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After creating an event, the browser redirects to the newly created
event's EventDetails page