UserContextValues's userRole in App now uses backend api to get user's role #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hknucsd-portal-dev ready! Built with commit e1bf9a0 |
|
Lmao since this needs the auth page refresh bug fix + legit test accounts the cypress literally cannot pass : ( |
|
Or well it needs the TODOs that I put in as comments at least. I left the TODOs there bc I thouht you'd have to do smth like that for the auth page refresh bug fix @godwinpang. Let me know if that is or isn't the case. If it isn't, I'll do the TODOs myself. |
godwinpang
requested changes
Sep 15, 2020
| // TODO: Add ApiConfigStore.setToken(token || '') here so getUserRole() works | ||
|
|
||
| const id = parseInt(claims.user_id, 10); | ||
| const userRole = await getUserRole(id); |
There was a problem hiding this comment.
don't await on both here - make them promises and do a promise.all - i want both awaits to go out together
…s role. It used to get the roles from firebase custom claims.
godwinpang
force-pushed
the
rbac_query_roles
branch
from
2f90db0 to
591a7cb
Compare
godwinpang
approved these changes
Sep 16, 2020
godwinpang
added a commit
that referenced
this pull request
Sep 20, 2020
…s role (#164) * UserContextValues's userRole in App now uses backend api to get user's role. It used to get the roles from firebase custom claims. * Add fixes. * Remove unused function. Co-authored-by: gypang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to get the roles from firebase custom claims.