Added create event button, page and form #162
Conversation
|
Deploy preview for hknucsd-portal-dev ready! Built with commit 0f2d063 |
| @@ -4,7 +4,7 @@ import { BaseAutocomplete } from '../base'; | |||
|
|
|||
| import { getMultipleUsers, getUserNames } from '@Services/UserService'; | |||
|
|
|||
| type OfficerNameData = { | |||
| export type OfficerNameData = { | |||
There was a problem hiding this comment.
should later standardize type vs interface for props - nbd though
There was a problem hiding this comment.
I'll probably be switching to using interface instead of type, since interface is more common in our codebase.
| @@ -46,3 +46,7 @@ export const OfficerNameAutocomplete = (props: OfficerAutocompleteProp) => { | |||
| /> | |||
| ); | |||
| }; | |||
|
|
|||
| OfficerNameAutocomplete.defaultProps = { | |||
There was a problem hiding this comment.
can drop defaultProps with line 20
There was a problem hiding this comment.
Weird enough, eslint gave me an error for not having defaultProps even tho I already set a default value lmao...
There was a problem hiding this comment.
You know any way of fixing that? Idk why it's happening lol. Worst case scenario I might have to turn that off by line
| @@ -23,4 +23,8 @@ const EventStatusDropdownField = (props: EventStatusFieldProp) => { | |||
| ); | |||
| }; | |||
|
|
|||
| EventStatusDropdownField.defaultProps = { | |||
There was a problem hiding this comment.
again can drop defaultProps given line 13
| @@ -23,4 +23,8 @@ const EventTypeDropdownField = (props: EventTypeFieldProp) => { | |||
| ); | |||
| }; | |||
|
|
|||
| EventTypeDropdownField.defaultProps = { | |||
| handleSubmit(values, setSubmitting); | ||
| }} | ||
| > | ||
| {({ submitForm, isSubmitting }) => ( |
There was a problem hiding this comment.
later extract out form into component to be reused - we should aim to extract out components sooner than later
| * This is for conditional rendering of component(s) at /events endpoint based on | ||
| * the endpoint's query parameters | ||
| */ | ||
| function QueriedEventPage(): JSX.Element { |
There was a problem hiding this comment.
we shouldn't have a separate page for this - we should be switching on params in '/events' instead
There was a problem hiding this comment.
What do you mean switching on params in '/events'? You mean do it at the App level?? Route's path prop doesn't recognize query params
There was a problem hiding this comment.
page level, /events and /events?x=true is the same page
There was a problem hiding this comment.
Yeah but we don't have a page on /events yet, the Get Involved/Events page is on /
There was a problem hiding this comment.
wait what's the calendar under? I think it would make sense to put it as events
There was a problem hiding this comment.
It's currently under /calendar
* Tsconfig changes again : ( * Added create event button, page and form.
* Tsconfig changes again : ( * Added create event button, page and form. Rebase modal_refactor's commits onto master branch (in progress)
Also added a QueriedEventPage to handle conditional rendering via query params on /events endpoint.