Added email verification to signup workflow, integrated auth api from backend. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… backend. Now frontend just needs to call createNewUser() from src/services/AuthService to start the signup workflow, then finishes it off with email verif. being handled in frontend.
|
Deploy preview for hknucsd-portal-dev ready! Built with commit 2b73995 |
godwinpang
requested changes
Sep 7, 2020
src/pages/SignUpPage/index.js
Outdated
| setSubmitting(false); | ||
| setSubmitting(false); | ||
| } catch { | ||
| // TODO: Let user know that an account has already been made with the email they provided |
There was a problem hiding this comment.
i think it would be better to isolate the calls into individual try catch blocks so we can see if createNewUser failed, or if verification email failed
| 5.0.0-beta2 |
godwinpang
previously approved these changes
Sep 8, 2020
godwinpang
pushed a commit
that referenced
this pull request
Sep 20, 2020
… backend. (#153) * Added email verification to signup workflow, integrated auth api from backend. Now frontend just needs to call createNewUser() from src/services/AuthService to start the signup workflow, then finishes it off with email verif. being handled in frontend. * Added try catch for calls to a firebase service in signup's handleSubmit. * Fixed duplicate imports in SignUpPage.
thai-truong
added a commit
that referenced
this pull request
Oct 3, 2020
… backend. (#153) * Added email verification to signup workflow, integrated auth api from backend. Now frontend just needs to call createNewUser() from src/services/AuthService to start the signup workflow, then finishes it off with email verif. being handled in frontend. * Added try catch for calls to a firebase service in signup's handleSubmit. * Fixed duplicate imports in SignUpPage. Rebase modal_refactor's 3 commits onto master (in progress)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now frontend just needs to call createNewUser() from
src/services/AuthService to start the signup workflow, then finishes it
off with email verif. being handled in frontend.