Public page layout component #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not even going to think about touching SignUpPage
|
Deploy preview for hkn-ucsd-portal-dev ready! Built with commit 6da8ad2 |
thai-truong
approved these changes
Sep 3, 2020
| <Grid | ||
| className={classes.root} | ||
| container | ||
| direction='row' |
There was a problem hiding this comment.
Just curious as to why you picked direction row here. Is it so that the whole screen is utilized, at least horizontally, if there are multiple children? Or does it just make sense from a design standpoint?
There was a problem hiding this comment.
great question
idk
it looks fine and will be encapsulated anyways :)
thai-truong
reviewed
Sep 3, 2020
| alignItems='center' | ||
| > | ||
| <Grid item className={classes.children}> | ||
| {children} |
There was a problem hiding this comment.
Also, is this grid item going to hold all of children, even when children can have multiple components? I thought grid item is usually used for only one component.
There was a problem hiding this comment.
it'll just be one thing
godwinpang
added a commit
that referenced
this pull request
Sep 20, 2020
* Make document body fill viewport. * Add PublicPageLayout component with story. * Update pages to use public page layout. Not even going to think about touching SignUpPage * Add spacing so content is not squished on mobile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create reusable layout component for all public facing pages (event rsvp+signin, signin, signup, future scheduling forms.)