Signuppage ui fix #144
Merged
Signuppage ui fix #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honestly idk what's different - probably line endings.
|
Deploy preview for hkn-ucsd-portal-dev ready! Built with commit 95432ca |
thai-truong
approved these changes
Aug 30, 2020
| signUpButton: { | ||
| marginTop: '10px', | ||
| signUp: { | ||
| marginTop: 8, |
There was a problem hiding this comment.
What does 8 mean here? 8 pixels?
There was a problem hiding this comment.
yeah 8 converts to px for material ui css :)
| marginTop: '37px', | ||
| marginBottom: '37px', | ||
| paddingBottom: '20px', | ||
| [theme.breakpoints.up('sm')]: { |
There was a problem hiding this comment.
What is this? Just curious cuz I really don't know LOL
There was a problem hiding this comment.
There was a problem hiding this comment.
just a nice wrapper around media queries that mui gives us
godwinpang
added a commit
that referenced
this pull request
Sep 20, 2020
* Add autochanged tsconfig. * Make signup page responsive. * Drop minWidth on dropdowns to prevent overflow.
thai-truong
pushed a commit
that referenced
this pull request
Oct 3, 2020
* Add autochanged tsconfig. * Make signup page responsive. * Drop minWidth on dropdowns to prevent overflow. Rebase commits from modal_refactor onto master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #140
kinda wip but you can preview it now - I'll go ahead and fix the minwidth stuff on the dropdown as well
edit: completely done :)