Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1889]: Adding template to nextjs to fix history change with GA4 #1996

Merged
merged 2 commits into from
May 13, 2024

Conversation

btabaska
Copy link
Collaborator

@btabaska btabaska commented May 13, 2024

Summary

Fixes #1889

Time to review: 2 mins

Changes proposed

Added a client useEffect that will fire GA4 page change whenever a page is loaded

Context for reviewers

vercel/next.js#58924

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

Copy link

Coverage report for ./frontend

St.
Category Percentage Covered / Total
🟢 Statements 84.11% 868/1032
🟡 Branches 65.01% 223/343
🟡 Functions 75.58% 164/217
🟢 Lines 84.15% 807/959

Test suite run success

164 tests passing in 56 suites.

Report generated by 🧪jest coverage report action from 687c974

@btabaska btabaska merged commit 14e803e into main May 13, 2024
10 checks passed
@btabaska btabaska deleted the btabaska/1889-fix-history-change-GA4-and-nextjs branch May 13, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add GA4 tracking for click-through-rate from search results to the opportunity listing
2 participants