Changes for related data update. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds files for schema version v1.1.1 with symlinks.
Adds the related_to_table_dois var to submission_schema.json.
Adds the related recids var to submission_schema.json to accommodate for related recids..
Updates the schema version number to 1.1.1 in the json files (forgot).
Adds the updated schema version (1.1.1) to the list of valid versions.
Updates schema version number referenced in the README document.
Upgrades the schema version used within code
Updates the schema version number used in the tests from 1.1.0 to 1.1.1
Updates the data type for related record id storage from string to integer. This is to disallow entry of anything other than HEPData record IDs.
Reverts a change upping the minimum version checked before running a number of validator functions. Was updated to match most recent version number, checks are actually needed above 1.1.0.
Fixed accidental inconsistencies between this data schema and the HEPData schema. Recids now has no maxLength value. Updated table DOI to match the correct maxLength value of 128 (was 64).
Now validates related DOI entries against a regular expression.
Updates TestHEPSubmission to include valid related doi/recid entries in submission.yaml
Adds invalid recid/doi testing and related test YAML files.
Removes a hardcoded flag setting the current schema version in testing as the default is to use the most recent version.
Adds the virtual environment folder in venv/ to the .gitignore file.
Probably unnecessary. Added a minimum value of 1 to disable entry of negative, and 0 as an integer.
Updates validator testing to include new cases for valid submissions, and more invalid cases.
Adds some extra checks against the regex in the related submission testing.
Removes spaces on array entries in the related test yaml files.
Adds a uniqueness check in the related DOI and record ID entries in the schema. Also adds testing against this functionality.
* Instead use 'related_to_hepdata_records' (suggested by @20DM). * Move new fields to end of 'properties' in JSON schema. * Bump version to 0.3.4 in preparation for new release.
GraemeWatt
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
This looks great! I've merged the latest changes from main, renamed related_to_hepdata_recids to related_to_hepdata_records (suggested by @20DM), moved the new fields to the end of the properties in the JSON schema, and bumped the version. I'll merge to main and make a new release v0.3.4 now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the validation changes and testing required for the related data update.
Closes #50.