Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that "cmenergies" keyword is numeric in submission schema #18

Closed
GraemeWatt opened this issue Apr 17, 2020 · 0 comments
Closed

Check that "cmenergies" keyword is numeric in submission schema #18

GraemeWatt opened this issue Apr 17, 2020 · 0 comments

Comments

@GraemeWatt
Copy link
Member

GraemeWatt commented Apr 17, 2020 •
edited
Loading

Modify the submission_schema.json file so that each value of the cmenergies keyword is a number not a string, unless the value is a range like 1.7-4.7 (used for records migrated from the old site).
GraemeWatt added a commit that referenced this issue Jun 7, 2020
@GraemeWatt
Check that each value of cmenergies keyword is numeric (closes #18)
1f98598 
* Move _get_major_version to Validator for SubmissionFileValidator use.
* Add check that each value of cmenergies are numeric or a range.
* Add test for check that cmenergies values are numeric or a range.
* Modify valid_submission.yaml for example of cmenergies as a range.
* Correct duplicate test_valid_submission_yaml_v1 function name.
* Add Python 3.7 and 3.8 to versions checked in Travis CI.
* Explain in README.rst how to pass 'data' for SubmissionFileValidator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GraemeWatt