-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpicc cleanup #4
Conversation
(2) add description to configure libfabric for running gpu margo test
@@ -1,4 +1,25 @@ | |||
This is an example script for executing an automated regression test on the | |||
To run the margo gpu test: gpu-margo-p2p-bw.cu with the current libfabric release, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think rather than explaining the modifications a user would need to do, we should instead just make a PR to the mochi-spack-packages repo with the changes needed and then just describe that libfabric needs to be configured with the --with-cuda variant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please do! That's exactly why we have our own libfabric package that inherits from the upstream one: so that we can add our own local variants/patches before they are available upstream. After we've tested it a bit we could contribute the +cuda variant to the spack maintainers, but we should start by just having it in our repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add the changes described here to llibfabric's package.py and create a PR at https://github.com/mochi-hpc/mochi-spack-packages.
No description provided.