Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow n-bit and scale offset filters in DCPL #288

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Allow n-bit and scale offset filters in DCPL #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hsds/util/dsetUtil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
("H5Z_FILTER_FLETCHER32", 3, "fletcher32"),
("H5Z_FILTER_SZIP", 4, "szip"),
("H5Z_FILTER_NBIT", 5, "nbit"),
("H5Z_FILTER_SCALEOFFSET", 6, "scaleoffet"),
("H5Z_FILTER_SCALEOFFSET", 6, "scaleoffset"),
("H5Z_FILTER_LZF", 32000, "lzf"),
("H5Z_FILTER_BLOSC", 32001, "blosclz"),
("H5Z_FILTER_SNAPPY", 32003, "snappy"),
Expand Down
2 changes: 2 additions & 0 deletions hsds/util/storUtil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ def getSupportedFilters(include_compressors=True):
"bitshuffle",
"shuffle",
"fletcher32",
"nbit", # No-op
"scaleoffset" # No-op
]
if include_compressors:
filters.extend(getCompressors())
Expand Down
2 changes: 1 addition & 1 deletion tests/integ/dataset_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1319,7 +1319,7 @@ def testInvalidCompressionFilter(self):
rspJson = json.loads(rsp.text)
self.assertTrue("root" in rspJson)

bad_compressors = ("shrink-o-rama", "scaleoffet")
bad_compressors = ("shrink-o-rama")
for compressor_name in bad_compressors:
# create the dataset
req = self.endpoint + "/datasets"
Expand Down
Loading