Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compression libs versions #156

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

byrnHDF
Copy link
Collaborator

@byrnHDF byrnHDF commented Nov 18, 2024

No description provided.

Copy link
Contributor

@brtnfld brtnfld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding updating versions, I would rather see an action, for example, https://github.com/marketplace/actions/dependencies-autoupdate, that automatically detects version updates in these packages and would do a PR to update them.

@byrnHDF
Copy link
Collaborator Author

byrnHDF commented Nov 18, 2024

Regarding updating versions, I would rather see an action, for example, https://github.com/marketplace/actions/dependencies-autoupdate, that automatically detects version updates in these packages and would do a PR to update them.

While having a check for updates is doable, the auto changes to code is not.

@byrnHDF
Copy link
Collaborator Author

byrnHDF commented Nov 18, 2024

We could add a workflow that reports the latest version available, but to compare that to values inside a file would need a bit of work. We do not have a "this is the versions of the compression libs we use" type of document.
We would have to parse either the cacheinit.cmake file or the CMakePresets.file for that info.

Copy link
Contributor

@brtnfld brtnfld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks okay if we minimize the manual steps involved in the future.

@byrnHDF
Copy link
Collaborator Author

byrnHDF commented Nov 18, 2024

Added create a json artifact for the compression libs involved (except bzip2 as they do not create any releases)

@byrnHDF byrnHDF merged commit c1e11d3 into HDFGroup:master Nov 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Build Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants