Work In Progress PR for initial feedback on layout callbacks. #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/sparse data
Merge develop to feature/sparse_data (HDFGroup#5154)
Implementation for the following structured chunk layout callbacks: --H5D__struct_chunk_lookup --H5D__struct_chunk_decode --H5D__struct_chunk_decode_defined_values -Note that <udata> is added an an input parameter to this routine --H5D__struct_chunk_new_chunk --H5D__struct_chunk_vector_read --H5D__struct_chunk_vector_write Note that these routines are not protected against [unused parameter] for now.
vchoi-hdfgroup
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
vchoi-hdfgroup
added
WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up Work In Progress PR for initial feedback.
Implementation for the following structured chunk layout callbacks:
--H5D__struct_chunk_lookup
--H5D__struct_chunk_decode
--H5D__struct_chunk_decode_defined_values
-Note that "udata" is added an an input parameter to this routine
--H5D__struct_chunk_new_chunk
--H5D__struct_chunk_vector_read
--H5D__struct_chunk_vector_write