-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop libaec fix #5182
Merged
Merged
Develop libaec fix #5182
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d597f00
Use the ${LIBAEC_PACKAGE_NAME} variable instead of SZIP
byrnHDF 426a7e8
Update documentation
byrnHDF 52a957e
Add to note
byrnHDF 9d8da39
Add help note
byrnHDF b609423
Merge branch 'HDFGroup:develop' into develop-libaec-fix
byrnHDF 5bd5b3e
Update doc notes
byrnHDF 543f38f
Update docs and some syntax errors
byrnHDF c036550
Correct typo
byrnHDF b1c5e2f
Update release note
byrnHDF db1dcae
Adjust paragraph
byrnHDF 123e06b
Adjust whitespace format
byrnHDF 6b5c39f
Merge branch 'HDFGroup:develop' into develop-libaec-fix
byrnHDF f6b4210
Merge branch 'HDFGroup:develop' into develop-libaec-fix
byrnHDF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -530,6 +530,14 @@ Bug Fixes since HDF5-2.0.0 release | |
|
||
Configuration | ||
------------- | ||
- Use pre-installed libaec compression library | ||
|
||
The CMake logic for finding the libaec compression library has been | ||
modified for a system-installed version of the library. Two options | ||
must be set, HDF5_ALLOW_EXTERNAL_SUPPORT:STRING=NO and *_USE_EXTERNAL:BOOL=OFF. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there is only one *_USE_EXTERNAL:BOOL=OFF option to set? Is it libaec_USE_EXTERNAL:BOOL=OFF, or one or more others? |
||
Note that disables building all plugins and external libraries in-line with the | ||
HDF5 library. In addition, the *_ROOT environment variables must be set. | ||
|
||
- Changed the zlib/szip compression find message to FATAL ERROR | ||
|
||
The message was changed to indicate that zlib/szip compression was requested and | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe (For libaec use -Dlibaec_* in place of -DSZIP_* for these options) would be clearer, if that is the actual meaning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the actual meaning indeed. The original SZIP package (under that name) is not only carrying code with problematic licence, it is very old as a conception. Currently, the only reliable SZIP compressor and encoder is provided by Libaec. Maybe some sites still support SZIP, but I consider that to be driven by purely anthropological interest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command "cmake -C ../<hdf5_src_dir>/config/cmake/cacheinit.cmake -G "Unix Makefiles" -DHDF5_ALLOW_EXTERNAL_SUPPORT:STRING="GIT" -DHDF5_ENABLE_ROS3_VFD=ON -DHDF5_ENABLE_ZLIB_SUPPORT=ON -DHDF5_ENABLE_SZIP_SUPPORT=ON -DHDF5_ENABLE_PLUGIN_SUPPORT=ON -DCMAKE_BUILD_TYPE:STRING=Release ../<hdf5_src_dir>" now downloads and builds szip from https://github.com/MathisRosenhauer/libaec.git using the code from byrnHDF:develop-libaec-fix.