Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Debugging HDF5 Applications to doxygen #5139

Merged
merged 9 commits into from
Nov 27, 2024

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Nov 21, 2024

Is this info even correct anymore?

@byrnHDF byrnHDF added Priority - 2. Medium ⏹ It would be nice to have this in the next release Component - Documentation Doxygen, markdown, etc. Type - Improvement Improvements that don't add a new feature or functionality labels Nov 21, 2024
@byrnHDF byrnHDF self-assigned this Nov 21, 2024
In addition to including the code at compile time the application must enable each package at
runtime. This is done by listing the package names in the HDF5_DEBUG environment variable. That
variable may also contain file descriptor numbers (the default is 2') which control the output
for all following packages up to the next file number. The word all` refers to all packages. Any
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these stray ' and ` in the 2 lines above?

Also should the ` in in line 287 be changed to '?

lrknox
lrknox previously approved these changes Nov 25, 2024
</table>
The components of the HDF5_DEBUG value may be separated by any non-lowercase letter.

\section sec_adddbg_trace API Tracing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially everything from this point down can just be removed since the API tracing functionality was removed a bit ago.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what I thought! Good so this goes away.

\section sec_adddbg_intro Introduction
The HDF5 library contains a number of debugging features to make programmers' lives
easier including the ability to print detailed error messages, check invariant
conditions, display timings and other statistics, and trace API function calls
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which would also warrant revision here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But wait - we still have H5ARG_TRACE and bin/trace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|trace|Updates H5ARG_TRACE macros in H5ES_insert() calls (run by autogen.sh)|

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They trace function calls just for internal use with the Async APIs but in general the H5TRACE macros were removed from all API routines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So safe to remove in this file - good!

Copy link
Collaborator

@jhendersonHDF jhendersonHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there are a couple other things here that could be modernized, but getting it into doxygen is a first step

@lrknox lrknox merged commit fff75d9 into HDFGroup:develop Nov 27, 2024
67 checks passed
@byrnHDF byrnHDF deleted the develop-doxy-debugging branch December 2, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Documentation Doxygen, markdown, etc. Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants