Make H5F_LIBVER_LATEST a real enum value #5083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was formerly a macro, but is now an enum value with the same value as the latest numbered API.
derobins
added
Priority - 2. Medium ⏹
derobins
requested review from
jhendersonHDF,
byrnHDF,
lrknox,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
derobins
commented
Nov 8, 2024
There was a problem hiding this comment.
The Java changes are just a re-ordering, putting LATEST in front of NBOUNDS
derobins
added
Priority - 3. Low 🔽
qkoziol
approved these changes
Nov 8, 2024
| H5F_LIBVER_V112 = 3, /**< Use the 1.12 file format for storing objects */ | ||
| H5F_LIBVER_V114 = 4, /**< Use the 1.14 file format for storing objects */ | ||
| H5F_LIBVER_V200 = 5, /**< Use the 2.0 file format for storing objects */ | ||
| H5F_LIBVER_LATEST = 5, /**< Use the latest file format for storing objects */ | ||
| H5F_LIBVER_NBOUNDS /**< Sentinel */ |
There was a problem hiding this comment.
We probably want to check what consequences this will have by making H5F_LIBVER_NBOUNDS inaccurate as a counting sentinel value. H5F_LIBVER_NBOUNDS is used in several places in the library.
brtnfld
approved these changes
Nov 11, 2024
byrnHDF
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was formerly a macro, but is now an enum value with the same value as the latest numbered API.