Update daily build action to build MPICH and OpenMPI from source #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendersonHDF
added
Priority - 2. Medium ⏹
jhendersonHDF
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
jhendersonHDF
commented
Nov 1, 2024
| @@ -53,8 +56,8 @@ jobs: | |||
|
|
|||
| # Enable threads=multiple for testing with Subfiling and | |||
| # VOL connectors that require MPI_THREAD_MULTIPLE | |||
| - name: Install MPICH (GCC) (Production) | |||
| if: ${{ steps.cache-mpich-ubuntu-gcc.cache-hit != 'true' && (inputs.build_mode != 'debug') }} | |||
There was a problem hiding this comment.
Fixed the caching here in both the MPICH and OpenMPI workflows; forgot to add the .outputs
jhendersonHDF
commented
Nov 1, 2024
| @@ -80,3 +83,13 @@ jobs: | |||
| --enable-threads=multiple | |||
| make -j2 | |||
| make install | |||
|
|
|||
| - name: Tar MPICH installation to preserve permissions for artifact | |||
| run: tar -cvf mpich.tar ${{ runner.workspace }}/mpich | |||
There was a problem hiding this comment.
Needed as a workaround. The default artifact zipping method doesn't preserve permissions, so GitHub mentions tar'ing first as a workaround.
byrnHDF
approved these changes
Nov 1, 2024
lrknox
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.