Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework FUNC_ENTER macros #5024

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Rework FUNC_ENTER macros #5024

merged 3 commits into from
Oct 29, 2024

Conversation

derobins
Copy link
Member

  • Makes naming more uniform
  • Unroll some macros to make it easier to see what each flavor of macro does

This adds some code duplication, but lowers confusion.

@derobins derobins added Priority - 2. Medium ⏹ It would be nice to have this in the next release Component - C Library Core C library issues (usually in the src directory) Type - Improvement Improvements that don't add a new feature or functionality labels Oct 28, 2024
@derobins derobins merged commit 1cd0168 into HDFGroup:develop Oct 29, 2024
61 checks passed
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Oct 31, 2024
@derobins @brtnfld
Rework FUNC_ENTER macros (HDFGroup#5024)
c5f5936 
* Initial cleanup of "prep" macros
* Cleanup of initialization routines
* Renamed init/push macros
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Nov 4, 2024
@derobins @brtnfld
Rework FUNC_ENTER macros (HDFGroup#5024)
05d22c0 
* Initial cleanup of "prep" macros
* Cleanup of initialization routines
* Renamed init/push macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkoziol qkoziol qkoziol approved these changes

@byrnHDF byrnHDF byrnHDF approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues (usually in the src directory) Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derobins @qkoziol @byrnHDF