Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix remaining CMake options except for CMake BUILD* variables #4990

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Prefix remaining CMake options except for CMake BUILD* variables #4990

merged 3 commits into from
Oct 22, 2024

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Oct 21, 2024

Renamed remaining HDF5 library CMake options except for CMake BUILD* variables

  DEFAULT_API_VERSION to HDF5_DEFAULT_API_VERSION
  DISABLE_PDB_FILES to HDF5_DISABLE_PDB_FILES
  ONLY_SHARED_LIBS to HDF5_ONLY_SHARED_LIBS
  ALLOW_UNSUPPORTED to HDF5_ALLOW_UNSUPPORTED
  TEST_SHELL_SCRIPTS to HDF5_TEST_SHELL_SCRIPTS

  All other HDF5 library CMake options are prefixed with HDF5_

@byrnHDF byrnHDF added Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Component - Documentation Doxygen, markdown, etc. Component - Build CMake, Autotools Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately Component - Misc Anything else (CODEOWNERS, etc.) Merge - To 2.0 labels Oct 21, 2024
@byrnHDF byrnHDF self-assigned this Oct 21, 2024
@byrnHDF
Copy link
Contributor Author

byrnHDF commented Oct 21, 2024

Closes #4982

@byrnHDF byrnHDF mentioned this pull request Oct 21, 2024
Closed
derobins
derobins reviewed Oct 21, 2024
View reviewed changes
src/H5build_settings.autotools.c.in Outdated
@@ -96,7 +96,7 @@ const char H5build_settings[]=
" Threads: @THREADS@\n"
" Threadsafety: @THREADSAFE@\n"
" Default API mapping: @DEFAULT_API_VERSION@\n"
" With deprecated public symbols: @DEPRECATED_SYMBOLS@\n"
" With deprecated public symbols:HDF5_DEFAULT_API_VERSIONS@\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Autotools symblol needs to stay the same

derobins
derobins reviewed Oct 21, 2024
View reviewed changes
src/libhdf5.settings.autotools.in Outdated
@@ -78,7 +78,7 @@ Dimension scales w/ new references: @DIMENSION_SCALES_WITH_NEW_REF@
Threads: @THREADS@
Threadsafety: @THREADSAFE@
Default API mapping: @DEFAULT_API_VERSION@
With deprecated public symbols: @DEPRECATED_SYMBOLS@
With deprecated public symbols:HDF5_DEFAULT_API_VERSIONS@
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs to be reverted

derobins
derobins requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@derobins derobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to revert Autotools files

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Oct 22, 2024

Need to revert Autotools files

Completed

@derobins derobins merged commit baa1e8e into HDFGroup:develop Oct 22, 2024
60 checks passed
qkoziol pushed a commit to qkoziol/hdf5 that referenced this pull request Oct 23, 2024
@byrnHDF @qkoziol
Prefix remaining CMake options except for CMake BUILD* variables (HDF…
f7915dc 
…Group#4990)
@byrnHDF byrnHDF deleted the develop-cmake-prefix branch October 25, 2024 18:33
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Oct 31, 2024
@byrnHDF @brtnfld
Prefix remaining CMake options except for CMake BUILD* variables (HDF…
250b058 
…Group#4990)
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Nov 4, 2024
@byrnHDF @brtnfld
Prefix remaining CMake options except for CMake BUILD* variables (HDF…
0bab29a 
…Group#4990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derobins derobins derobins approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Component - Documentation Doxygen, markdown, etc. Component - Misc Anything else (CODEOWNERS, etc.) Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byrnHDF @derobins