Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check in generated files in src #4981

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Check in generated files in src #4981

merged 2 commits into from
Oct 20, 2024

Conversation

derobins
Copy link
Member

These files are infrequently updated and generating them adds an annoying dependency on Perl. We're checking them in and will probably add a GitHub action to check if anything is stale when creating a PR.

Adds:
* H5Edefin.h
* H5Einit.h
* H5Emajdef.h
* H5Emindef.h
* H5Epubgen.h
* H5Eterm.h
* H5overflow.h
* H5version.h

@derobins
Check in generated files in src
61ef489 
These files are infrequently updated and generating them adds an
annoying dependency on Perl. We're checking them in and will
probably add a GitHub action to check if anything is stale
when creating a PR.

Adds:
    * H5Edefin.h
    * H5Einit.h
    * H5Emajdef.h
    * H5Emindef.h
    * H5Epubgen.h
    * H5Eterm.h
    * H5overflow.h
    * H5version.h
@derobins derobins added Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - C Library Core C library issues (usually in the src directory) Component - Build CMake, Autotools Type - Improvement Improvements that don't add a new feature or functionality Merge - To 2.0 labels Oct 19, 2024
@derobins
Copy link
Member Author

Adding these back in allows us to more easily test MinGW, which is a platform we care about.

@derobins
Copy link
Member Author

I'll add a GitHub issue to check for freshness at a later date

bmribler
bmribler approved these changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@bmribler bmribler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

qkoziol
qkoziol approved these changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@qkoziol qkoziol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have a dependency on Perl, ultimately...

@derobins derobins merged commit 680cdd0 into HDFGroup:develop Oct 20, 2024
8 checks passed
qkoziol pushed a commit to qkoziol/hdf5 that referenced this pull request Oct 23, 2024
@derobins @qkoziol
Check in generated files in src (HDFGroup#4981)
0c1eb7d 
These files are infrequently updated and generating them adds an
annoying dependency on Perl. We're checking them in and will
probably add a GitHub action to check if anything is stale
when creating a PR.

Adds:
    * H5Edefin.h
    * H5Einit.h
    * H5Emajdef.h
    * H5Emindef.h
    * H5Epubgen.h
    * H5Eterm.h
    * H5overflow.h
    * H5version.h
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Oct 31, 2024
@derobins @brtnfld
Check in generated files in src (HDFGroup#4981)
ae46e48 
These files are infrequently updated and generating them adds an
annoying dependency on Perl. We're checking them in and will
probably add a GitHub action to check if anything is stale
when creating a PR.

Adds:
    * H5Edefin.h
    * H5Einit.h
    * H5Emajdef.h
    * H5Emindef.h
    * H5Epubgen.h
    * H5Eterm.h
    * H5overflow.h
    * H5version.h
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Nov 4, 2024
@derobins @brtnfld
Check in generated files in src (HDFGroup#4981)
a703e13 
These files are infrequently updated and generating them adds an
annoying dependency on Perl. We're checking them in and will
probably add a GitHub action to check if anything is stale
when creating a PR.

Adds:
    * H5Edefin.h
    * H5Einit.h
    * H5Emajdef.h
    * H5Emindef.h
    * H5Epubgen.h
    * H5Eterm.h
    * H5overflow.h
    * H5version.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjala mattjala mattjala approved these changes

@bmribler bmribler bmribler approved these changes

@qkoziol qkoziol qkoziol approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - Build CMake, Autotools Component - C Library Core C library issues (usually in the src directory) Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derobins @qkoziol @bmribler @mattjala