Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out compiler flags into specific compiler files #4974

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Split out compiler flags into specific compiler files #4974

merged 6 commits into from
Oct 25, 2024

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Oct 18, 2024

No description provided.

@byrnHDF byrnHDF added Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - Build CMake, Autotools Type - Improvement Improvements that don't add a new feature or functionality Merge - To 2.0 labels Oct 18, 2024
@byrnHDF byrnHDF self-assigned this Oct 18, 2024
@lrknox lrknox merged commit 6122828 into HDFGroup:develop Oct 25, 2024
62 checks passed
@byrnHDF byrnHDF deleted the develop-compile-files branch October 25, 2024 18:33
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Oct 31, 2024
@byrnHDF @lrknox @brtnfld
Split out compiler flags into specific compiler files (HDFGroup#4974)
23fad2b 
* Split CMake HDFCompileFlags into specific compiler files

* Separate out CXX Flags

* Add Fortran compiler specific files

* Merge in HDFGroup#4816 changes and close HDFGroup#4816

* fix hanging endif

---------

Co-authored-by: Larry Knox <[email protected]>
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Nov 4, 2024
@byrnHDF @lrknox @brtnfld
Split out compiler flags into specific compiler files (HDFGroup#4974)
a31fdb6 
* Split CMake HDFCompileFlags into specific compiler files

* Separate out CXX Flags

* Add Fortran compiler specific files

* Merge in HDFGroup#4816 changes and close HDFGroup#4816

* fix hanging endif

---------

Co-authored-by: Larry Knox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjala mattjala mattjala approved these changes

@lrknox lrknox lrknox approved these changes

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byrnHDF @lrknox @mattjala