Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch HDoff_t from __int64 to int64_t on Windows #4973

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Switch HDoff_t from __int64 to int64_t on Windows #4973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion release_docs/RELEASE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ New Features
POSIX large-file support (LFS). On Windows, however, off_t is defined
as a 32-bit type, even on 64-bit Windows.

HDoff_t has been added to H5public.h and is defined to be __int64 on
HDoff_t has been added to H5public.h and is defined to be int64_t on
Windows and the library has been updated to use HDoff_t in place of
off_t throughout. The H5Pset_external() offset parameter has also been
updated to be HDoff_t.
Expand Down
6 changes: 3 additions & 3 deletions src/H5public.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,14 +301,14 @@ typedef long long ssize_t;
typedef uint64_t hsize_t;

/* off_t exists on Windows, but is always a 32-bit long, even on 64-bit Windows,
* so on Windows we define HDoff_t to be __int64, which is the type of the
* st_size field of the _stati64 struct.
* so on Windows we define HDoff_t to be int64_t, which is equivalent to __int64,
* the type of the st_size field of the _stati64 struct.
*/
#ifdef H5_HAVE_WIN32_API
/**
* Platform-independent offset
*/
typedef __int64 HDoff_t;
typedef int64_t HDoff_t;
#else
/**
* Platform-independent offset
Expand Down
Loading