Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow that reports to CDash #4864

Merged
merged 36 commits into from
Sep 26, 2024
Merged

Add workflow that reports to CDash #4864

merged 36 commits into from
Sep 26, 2024

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Sep 20, 2024

No description provided.

@byrnHDF byrnHDF added Merge - To 1.14 Priority - 2. Medium ⏹ It would be nice to have this in the next release Component - Testing Code in test or testpar directories, GitHub workflows Component - Build CMake, Autotools Type - Improvement Improvements that don't add a new feature or functionality Component - Misc Anything else (CODEOWNERS, etc.) labels Sep 20, 2024
@byrnHDF byrnHDF self-assigned this Sep 20, 2024
mattjala
mattjala reviewed Sep 25, 2024
View reviewed changes
config/cmake/examples/CTestScript.cmake Outdated
set (CTEST_SITE "${HOSTNAME}${CTEST_SITE_EXT}")
#find_program (HOSTNAME_CMD NAMES hostname)
#execute_process (COMMAND ${HOSTNAME_CMD} OUTPUT_VARIABLE HOSTNAME OUTPUT_STRIP_TRAILING_WHITESPACE)
#set (CTEST_SITE "${HOSTNAME}${CTEST_SITE_EXT}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should be removed unless there's a specific reason to keep this around

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allen's not sure whether or not this change will be permanent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

mattjala
mattjala reviewed Sep 25, 2024
View reviewed changes
config/cmake/scripts/CTestScript.cmake Outdated
set (CTEST_SITE "${HOSTNAME}${CTEST_SITE_EXT}")
#find_program (HOSTNAME_CMD NAMES hostname)
#execute_process (COMMAND ${HOSTNAME_CMD} OUTPUT_VARIABLE HOSTNAME OUTPUT_STRIP_TRAILING_WHITESPACE)
#set (CTEST_SITE "${HOSTNAME}${CTEST_SITE_EXT}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

hyoklee
hyoklee reviewed Sep 25, 2024
View reviewed changes
.github/workflows/cmake-script.yml
@@ -468,8 +468,9 @@ jobs:
set (CTEST_DROP_SITE_INIT "my.cdash.org")
# Change following line to submit to your CDash dashboard to a different CDash project
#set (CTEST_DROP_LOCATION_INIT "/submit.php?project=HDF5")
#set (CMAKE_GENERATOR_TOOLSET "Intel C++ Compiler 2024,fortran=ifx")
set (CMAKE_GENERATOR_TOOLSET "Intel C++ Compiler 2024,fortran=ifx")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is fortran=ifx necessary?

See -DHDF5_BUILD_FORTRAN:BOOL=OFF in line 476.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the next PR when I fix Intel compiling I will enable fortran

@lrknox lrknox merged commit a852029 into HDFGroup:develop Sep 26, 2024
56 checks passed
@byrnHDF byrnHDF deleted the develop-add-cdash branch September 26, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjala mattjala mattjala left review comments

@lrknox lrknox lrknox approved these changes

@hyoklee hyoklee hyoklee approved these changes

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Component - Misc Anything else (CODEOWNERS, etc.) Component - Testing Code in test or testpar directories, GitHub workflows Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
Downstream HDF5 Merges
Status: Needs Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@byrnHDF @hyoklee @lrknox @mattjala