Change name of libhdf5hl_fortran installed by autotools #4811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_fortran to be consistent with CMake install and with other hl lib files. Switched corresponding symlink to libhdf5hl_fortran. Fixes issue HDFGroup#4684.
lrknox
requested review from
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
byrnHDF
approved these changes
Sep 6, 2024
lrknox
added
Merge - To 1.14
Priority - 1. High 🔼
Fix typo in code to create link to libhdf5_hl_fortran.a.
lrknox
added
Type - Bug / Bugfix
|
The issue was flagged for 1.16 - is this the kind of thing we should delay until the next major update to avoid surprising users? |
|
This can go in now, but should be develop only. Renaming libraries should only be done in a major release. |
derobins
added
Merge - Develop Only
|
Also, this needs a RELEASE.txt entry |
derobins
added
Merge - To 1.14
Merge - Develop Only
|
Decision is to:
|
libhdf5hl_fortran. Add RELEASE.txt entry about changeing name libhdf5hl_fortran to libhdf5_hl_fortran.
derobins
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to libhdf5_hl_fortran to be consistent with CMake install and with other hl lib files. Switched corresponding symlink to libhdf5hl_fortran.
Fixes issue #4684.