Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary fix for ARM64 Mac _Float16 build failure #4639

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Add temporary fix for ARM64 Mac _Float16 build failure #4639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
435ab8f
Add temporary fix for ARM64 Mac _Float16 build failure
jhendersonHDF Jul 10, 2024
37114ef
Merge remote-tracking branch 'canonical/develop' into temp_aarch64_fl…
lrknox Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main-cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
# but that seems unnecessary
- name: "MacOS Clang"
os: macos-latest
cpp: OFF
cpp: ON
fortran: ON
java: ON
docs: ON
Expand Down
8 changes: 7 additions & 1 deletion src/H5private.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,8 +586,14 @@
* _Float16 type to avoid issues when compiling the library
* with the -pedantic flag or similar where we get warnings
* about _Float16 not being an ISO C type.
*
* Due to the inclusion of H5private.h from the C++ wrappers,
* this typedef creation must be avoided when __cplusplus is
* defined to avoid build failures on ARM64 Macs. GCC and
* Clang either do not currently provide a _Float16 type for
* C++ on ARM64, or may need an additional compile-time flag.
*/
#ifdef H5_HAVE__FLOAT16
#if defined(H5_HAVE__FLOAT16) && !defined(__cplusplus)
#if defined(__GNUC__)
__extension__ typedef _Float16 H5__Float16;
#else
Expand Down
Loading