Removed h5test.* from the C++ test #4629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised the C++ tests to eliminate the use of private header files. The solution is to use some functions in the tools library and duplicate some functions from h5test.*. Some of these duplicated functions can be added to the tools library at a later time, however. Also, there are many small changes to improve the overall outputs of the tests. Note: The changes to c++/test/Makefile.in will be committed soon. (Issue HDFGroupGH-4517)
bmribler
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
glennsong09,
mattjala and
brtnfld
as code owners
…hdf5_bmr23 into fix_cpp_test_noprivate
Removed commented line
|
Need to change the CMakeLists.txt file needs the same changes as Makefile.am. |
byrnHDF
approved these changes
Jul 10, 2024
|
This works, but from a maintenance perspective I don't know that duplicating a bunch of the library's testing framework is really the way that you'd want to go with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised the C++ tests to eliminate the use of private header files. The solution is to use some functions in the tools library and duplicate some functions from h5test.*. Some of these duplicated functions can be added to the tools library at a later time, however.
Also, there are many small changes to improve the overall outputs of the tests.
Note: The changes to c++/test/Makefile.am will be committed soon.
(Issue GH-4517)