Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI type correction #4268

Merged
merged 3 commits into from
Mar 28, 2024
Merged

MPI type correction #4268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f240cd4
corrected type for MPI_*_f2c APIs
brtnfld Mar 27, 2024
d347a2b
fixed return type of callback
brtnfld Mar 27, 2024
32a8544
reset compilation flags of logical test program
brtnfld Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions fortran/src/H5Pf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4606,8 +4606,8 @@ h5pset_fapl_mpio_c(hid_t_f *prp_id, void *comm, void *info)
herr_t ret;
MPI_Comm c_comm;
MPI_Info c_info;
c_comm = MPI_Comm_f2c(*((int *)comm));
c_info = MPI_Info_f2c(*((int *)info));
c_comm = MPI_Comm_f2c(*((MPI_Fint *)comm));
c_info = MPI_Info_f2c(*((MPI_Fint *)info));

/*
* Call H5Pset_mpi function.
Expand Down Expand Up @@ -4677,8 +4677,8 @@ h5pset_mpi_params_c(hid_t_f *prp_id, void *comm, void *info)
herr_t ret;
MPI_Comm c_comm;
MPI_Info c_info;
c_comm = MPI_Comm_f2c(*((int *)comm));
c_info = MPI_Info_f2c(*((int *)info));
c_comm = MPI_Comm_f2c(*((MPI_Fint *)comm));
c_info = MPI_Info_f2c(*((MPI_Fint *)info));

/*
* Call H5Pset_mpi_params.
Expand Down
2 changes: 1 addition & 1 deletion fortran/test/tH5P_F03.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ MODULE test_genprop_cls_cb1_mod

CONTAINS

INTEGER FUNCTION test_genprop_cls_cb1_f(list_id, create_data ) bind(C)
INTEGER(KIND=C_INT) FUNCTION test_genprop_cls_cb1_f(list_id, create_data ) bind(C)

IMPLICIT NONE

Expand Down
4 changes: 3 additions & 1 deletion m4/aclocal_fc.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,8 @@ AC_DEFUN([PAC_FIND_MPI_LOGICAL_KIND],[
AC_REQUIRE([PAC_FC_AVAIL_KINDS])
AC_MSG_CHECKING([default Fortran KIND of LOGICAL in MPI])
AC_LANG_PUSH([Fortran])

saved_FCFLAGS=$FCFLAGS
FCFLAGS=""
for kind in `echo $pac_validLogicalKinds | sed -e 's/,/ /g'`; do
AC_COMPILE_IFELSE([
PROGRAM main
Expand All @@ -411,6 +412,7 @@ else
AC_DEFINE_UNQUOTED([MPI_LOGICAL_KIND], [$PAC_MPI_LOGICAL_KIND], [Define MPI Fortran KIND of LOGICAL])
AC_MSG_RESULT([$PAC_MPI_LOGICAL_KIND])
fi
FCFLAGS=$saved_FCFLAGS
AC_LANG_POP([Fortran])
])

Expand Down
3 changes: 3 additions & 0 deletions release_docs/RELEASE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1770,6 +1770,9 @@ Known Problems
implemented: (1) derived type argument passed by value (H5VLff.F90),
and (2) support for REAL with KIND = 2 in intrinsic SPACING used in testing.

Fortran tests HDF5_1_8.F90 and HDF5_F03.F90 will fail with Cray compilers greater than
version 16.0 due to a compiler bug. The latest version verified as failing was version 17.0.

Several tests currently fail on certain platforms:
MPI_TEST-t_bigio fails with spectrum-mpi on ppc64le platforms.

Expand Down
Loading