Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested header footer for NEWSLETTER #4204

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Suggested header footer for NEWSLETTER #4204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39b6b8e
Suggested header footer for NEWSLETTER
byrnHDF Mar 21, 2024
8474a9a
Updates
byrnHDF Mar 21, 2024
52eedda
Add NEWSLETTER.txt to h5vers script
byrnHDF Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions bin/h5vers
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,10 @@ die "unable to read file: $README\n" unless -r $file;
my $RELEASE = $file;
$RELEASE =~ s/[^\/]*$/..\/release_docs\/RELEASE.txt/;
die "unable to read file: $RELEASE\n" unless -r $file;
# release_docs/NEWSLETTER.txt
my $NEWS = $file;
$NEWS =~ s/[^\/]*$/..\/release_docs\/NEWSLETTER.txt/;
die "unable to read file: $NEWS\n" unless -r $file;
# configure.ac
my $CONFIGURE = $file;
$CONFIGURE =~ s/[^\/]*$/..\/configure.ac/;
Expand Down Expand Up @@ -247,6 +251,7 @@ if ($set) {
# Nothing to do but print result
$README = "";
$RELEASE = "";
$NEWS = "";
$CONFIGURE = "";
$CPP_DOC_CONFIG = "";
$LT_VERS = "";
Expand Down Expand Up @@ -329,6 +334,20 @@ if ($RELEASE) {
close FILE;
}

# Update the release_docs/NEWSLETTER.txt file
if ($NEWS) {
open FILE, $NEWS or die "$NEWS: $!\n";
my @contents = <FILE>;
close FILE;
$contents[0] = sprintf("HDF5 version %d.%d.%d%s %s",
@newver[0,1,2],
$newver[3] eq "" ? "" : "-".$newver[3],
"currently under development\n");
open FILE, ">$NEWS" or die "$NEWS: $!\n";
print FILE @contents;
close FILE;
}

# Update the c++/src/cpp_doc_config file
if ($CPP_DOC_CONFIG) {
my $data = read_file($CPP_DOC_CONFIG);
Expand Down
9 changes: 9 additions & 0 deletions release_docs/NEWSLETTER.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
Release of HDF5 1.14.4 Library and Tools is now available from the HDF5 Releases page.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a header and footer in the NEWSLETTER file for HDF4? This seems like just another thing that has to be updated with new release version branches.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This copies what is on the NEWSLETTER website.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is simple to add it to the list of files to change in the vers script.

Copy link
Collaborator

@jhendersonHDF jhendersonHDF Mar 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured the idea was to have a file that's empty other than the entries just so there's a quick reference to pull from. But, no complaints about the header and footer; just wanting to avoid putting version numbers anywhere they aren't exactly needed since it just adds to the maintenance burden. If h5vers can handle it though, great!


This is a maintenance release with a few changes and updates:
----------------------------------------------------------------------------

* Added support for _Float16 16-bit floating-point datatype

Support for the 16-bit floating-point _Float16 C type has been added to
Expand All @@ -8,3 +13,7 @@
data and data of another HDF5 datatype.

(GitHub #4065, #2154)

----------------------------------------------------------------------------
Please see the full release notes for detailed information regarding this release,
including a detailed list of changes.
Loading