Note that the description for system errors may be used by h5py #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
requested review from
derobins,
fortnern,
jhendersonHDF,
jrmainzer,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
|
I am not disagreeing with the idea, just the content of the message. |
|
That makes sense; I've updated the comment. |
|
Nice! |
qkoziol
approved these changes
Oct 15, 2020
derobins
approved these changes
Oct 15, 2020
|
Thanks! I am planning to only rely on the errno part. Specifically, we're likely to match it with a regex like |
mattjala
pushed a commit
to mattjala/hdf5
that referenced
this pull request
Jan 9, 2025
) Makes testing parameters specified with AddTest non-const again when passed to test functions. This allows test functions to update their parameters during execution and is particularly useful for tests which use those parameters to accumulate statistics, error counts, etc. without resorting to global variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion on #34, we decided that this could simply be a comment in the source code. The string format here has been stable for 11 years (since a443284), so hopefully there's no major pressure to change it.
We're just about to release h5py 3.0, so we'll look into getting the errno from the string after that.