Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some warnings in developer builds (#3247) #3291

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix some warnings in developer builds (#3247) #3291

merged 1 commit into from
Jul 27, 2023

Conversation

jhendersonHDF
Copy link
Collaborator

  • Fix some warnings in developer builds

  • Switch approach to Winline flag

@jhendersonHDF jhendersonHDF added Merge Use this label when a PR is for a downstream merge Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Component - Build CMake, Autotools Type - Task Actions that don't fit into any other type category Branch - 1.14 labels Jul 27, 2023
@jhendersonHDF
Fix some warnings in developer builds (HDFGroup#3247)
eb3df4c 
* Fix some warnings in developer builds

* Switch approach to Winline flag
@derobins derobins merged commit 2bb4c90 into HDFGroup:hdf5_1_14 Jul 27, 2023
@jhendersonHDF jhendersonHDF deleted the 1_14-aab497a6312a9d8434a7dc7b5a593713fc8fbce0 branch August 31, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - Build CMake, Autotools Merge Use this label when a PR is for a downstream merge Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Task Actions that don't fit into any other type category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhendersonHDF @byrnHDF @derobins