Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set minimal permissions on GitHub Workflows #2980

Merged
merged 1 commit into from
May 18, 2023

Conversation

diogoteles08
Copy link
Contributor

Closes #2973

I've tried to evaluate the permissions needed to all your workflows but I couldn't be 100% sure of some of them. It went all fine in my testings on the fork, but if you have any issues on runs on your repo, we might need to add some extra permissions.

@byrnHDF byrnHDF self-assigned this May 18, 2023
@byrnHDF byrnHDF added Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality labels May 18, 2023
Copy link
Collaborator

@jhendersonHDF jhendersonHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @diogoteles08!

@lrknox lrknox merged commit 14edcfa into HDFGroup:develop May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Set minimal permissions on GitHub Workflows
4 participants