HL GIF tools changes #2360
Merged
HL GIF tools changes #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derobins
commented
Dec 23, 2022
derobins
commented
- Fixes the broken Autotools option
- Removes the "build HL tools" option
* Fixes the broken Autotools option * Removes the "build HL tools" option
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler and
raylu-hdf
as code owners
derobins
commented
Dec 23, 2022
| HL_TOOLS="tools" | ||
| else | ||
| AC_MSG_RESULT([no]) | ||
| fi |
There was a problem hiding this comment.
This option was added to disable the GIF tools,. Now that we have a specific option for that, there's no reason to have a separate option for the HL tools.
lrknox
approved these changes
Dec 24, 2022
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
May 17, 2023
* Fixes the broken Autotools option * Removes the "build HL tools" option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.