Disable hl tools by default #2313
Conversation
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler and
raylu-hdf
as code owners
| @@ -301,6 +301,14 @@ Bug Fixes since HDF5-1.13.3 release | |||
|
|
|||
| Configuration | |||
| ------------- | |||
| - Change the default for building the high-level tools | |||
There was a problem hiding this comment.
I wonder if it might be good to call out which tools are getting disabled here by default since I imagine some folks would want to know that building of h5watch is opt-in after this.
There was a problem hiding this comment.
Agree. The tools are gif2hdf and hdf2gif as well as h5watch
release_docs/RELEASE.txt
Outdated
| @@ -301,6 +301,14 @@ Bug Fixes since HDF5-1.13.3 release | |||
|
|
|||
| Configuration | |||
| ------------- | |||
| - Change the default for building the high-level tools | |||
|
|
|||
| The gif2hdf5, hdf2gif and h5watch high-level tools are deprecated and will be removed | |||
There was a problem hiding this comment.
Is h5watch really deprecated?
There was a problem hiding this comment.
All three tools get disabled.
There was a problem hiding this comment.
I could split the line to make h5watch in a sentence by itself. A bit confusing though.
|
We shouldn’t be removing h5watch. What is the reason?
…On Fri, Dec 16, 2022 at 3:26 PM Allen Byrne ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In release_docs/RELEASE.txt
<#2313 (comment)>:
> @@ -301,6 +301,14 @@ Bug Fixes since HDF5-1.13.3 release
Configuration
-------------
+ - Change the default for building the high-level tools
+
+ The gif2hdf5, hdf2gif and h5watch high-level tools are deprecated and will be removed
All three tools get disabled.
—
Reply to this email directly, view it on GitHub
<#2313 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLFT3L4OBKE22FLRHISYL3WNTM7FANCNFSM6AAAAAATBJDVC4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
It's just an artifact from disabling the gif tools. It's not being deprecated. The text just needs some improvement. |
| - Change the default for building the high-level tools | ||
|
|
||
| The gif2hdf5 and hdf2gif high-level tools are deprecated and will be removed | ||
| in a future release. The default build setting for them have been changed from enabled |
There was a problem hiding this comment.
| in a future release. The default build setting for them have been changed from enabled | |
| in a future release. The default build setting for them has been changed from enabled |
| to disabled. A user can enable the build of these tools if needed. | ||
| autotools: --enable-hlgiftools | ||
| cmake: HDF5_BUILD_HL_GIF_TOOLS=ON | ||
|
|
There was a problem hiding this comment.
| The gif2h5 and h52gif tools were previously enabled or disabled by the --enable-hltools / HDF5_BUILD_HL_TOOLS option. That option also controlled building and installing the h5watch tool, which will continue to be built and installed by default but may be disabled using that option. |
| @@ -301,6 +301,16 @@ Bug Fixes since HDF5-1.13.3 release | |||
|
|
|||
| Configuration | |||
| ------------- | |||
| - Change the default for building the high-level tools | |||
|
|
|||
| The gif2hdf5 and hdf2gif high-level tools are deprecated and will be removed | |||
There was a problem hiding this comment.
| The gif2hdf5 and hdf2gif high-level tools are deprecated and will be removed | |
| The gif2h5 and h52gif high-level tools are deprecated and will be removed |
c1e44d3 Fix doxygen warnings and remove javadocs (HDFGroup#2324) 149b8e9 Disable hl tools by default (HDFGroup#2313)
* Brings the following changesets over from develop: b9244a8 Align arg types of H5D_chunk_iter_op_t with H5Dget_chunk_info (#2074) 70cf2c3 Removed idioms and misc. text clean-up (#2320) 8102fa8 Only document Fortran functions (#2319) 784061b moved onion VFD to FAPL group (#2321) 6b6bcde Hdffv 11052 (#2315) 10c693a Update hdf5_header.html 0cb5808 Hdffv 11052 (#2303) a1c81ed added doc. warning for H5Literate_async return value (#2295) 502b32b Updated H5ES documenation (#2293) a903600 Fix for HDFFV-11052: h5debug fails on a corrupted file (h5_nrefs_POC)… (#2291) * Brings the following changes over from develop: c1e44d3 Fix doxygen warnings and remove javadocs (#2324) 149b8e9 Disable hl tools by default (#2313)
* Disable hl tools by default * identify the tools * Only GIF tools are depecated * Add new option * Update autotools
No description provided.