Adds 'unused' hints for MDS io_info parameters #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler and
raylu-hdf
as code owners
byrnHDF
approved these changes
Dec 14, 2022
|
This is for sure going to fail the formatting check. For one of the calls, I opted to use (void) instead of an ATTR_UNUSED macro. We don't have one for "used in debug parallel only" and those macros are already ridiculous. |
|
Once this is merged, I'll fix the GitHub actions that are incorrectly using the default build mode. |
derobins
commented
Dec 14, 2022
jhendersonHDF
approved these changes
Dec 14, 2022
derobins
commented
Dec 14, 2022
src/H5Dchunk.c
Outdated
| HDassert(io_info); | ||
| #else | ||
| /* clang-format off */ |
There was a problem hiding this comment.
wtf? Must be due to the FUNC_ENTER macro.
There was a problem hiding this comment.
This is less ugly, and I have zero interest in adding to the already-over-complicated ATTR_UNUSED scheme
byrnHDF
approved these changes
Dec 14, 2022
derobins
added a commit
to derobins/hdf5
that referenced
this pull request
Dec 15, 2022
* Adds 'unused' hints for MDS io_info parameters * Committing clang-format changes * Fix issue with formatter * Committing clang-format changes * Final fix for formatter * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
derobins
added a commit
that referenced
this pull request
Dec 16, 2022
* Adds 'unused' hints for MDS io_info parameters * Committing clang-format changes * Fix issue with formatter * Committing clang-format changes * Final fix for formatter * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
May 17, 2023
* Adds 'unused' hints for MDS io_info parameters * Committing clang-format changes * Fix issue with formatter * Committing clang-format changes * Final fix for formatter * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.