Subfiling updates for release #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendersonHDF
requested review from
byrnHDF,
bmribler,
ChristopherHogan,
gnuoyd,
derobins,
jrmainzer,
qkoziol,
fortnern,
soumagne,
vchoi-hdfgroup and
lrknox
as code owners
jhendersonHDF
force-pushed
the
feature/subfiling
branch
from
3d84c15 to
85a3143
Compare
derobins
reviewed
Aug 3, 2022
| [MPIO_VFD_IDX] = "mpio", | ||
| [ROS3_VFD_IDX] = "ros3", | ||
| [HDFS_VFD_IDX] = "hdfs", | ||
| [SUBFILING_VFD_IDX] = H5FD_SUBFILING_NAME, |
There was a problem hiding this comment.
Should we define the other names as constants as well?
There was a problem hiding this comment.
It would probably be a good idea to keep strings in one single place and use a macro everywhere else. I don't know how many VFDs follow this pattern though. Some of them may need some tweaks.
There was a problem hiding this comment.
We don't have to make all the changes here. We can have separate PRs later to address orthogonal issues like this.
derobins
reviewed
Aug 3, 2022
| /* This enum should match the entries in the above 'volnames' | ||
| * since they are indices into the 'volnames' array. */ | ||
| /* This enum should match the entries in the 'volnames' | ||
| * array since they are indices into that array. */ | ||
| typedef enum { | ||
| NATIVE_VOL_IDX = 0, | ||
| PASS_THROUGH_VOL_IDX, | ||
| } vol_idx; |
There was a problem hiding this comment.
We should probably do the same this with the VOL array that we do with the VFD array.
There was a problem hiding this comment.
Agreed. Anything to make the maintainability there better.
byrnHDF
approved these changes
Aug 3, 2022
derobins
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.