Hdf5 1 12 Miscellaneous warnings fixes #1718

jhendersonHDF · 2022-05-03T04:42:34Z

Also cherry picks a few relevant commits from develop.

The operations that were changed are fundamentally not const since the shadow operation can modify the node structure when SWMR is in use.

…DFGroup#1171) * Avoid calling H5Ropen_object with a misaligned H5R_ref_t: copy the raw H5R_ref_t bytes to a heap buffer that's known to have the right alignment. * Committing clang-format changes * Use an automatic H5R_ref_t instead of malloc'ing one. Go ahead and initialize the H5R_ref_t to all-0s so that arbitrary stack content doesn't foul things up. Bail out with an error if `size` exceeds `sizeof(H5R_ref_t)`. * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

jhendersonHDF · 2022-05-03T04:44:48Z

hl/src/H5PT.c

@@ -29,7 +29,7 @@ static H5I_type_t H5PT_ptable_id_type = H5I_UNINIT;
 #define H5PT_HASH_TABLE_SIZE 64

 /* Packet Table private functions */
-static herr_t H5PT_free_id(void *id, void **_ctx);
+static herr_t H5PT_free_id(void *id);


The ctx parameter was added to the public H5I_free_t typedef in 1.13 for async operations, but isn't in the 1.12 branch.

jhendersonHDF · 2022-05-03T04:45:09Z

src/H5B2int.c

-                                               unsigned end_idx, void *old_parent, void *new_parent);
+static herr_t H5B2__update_child_flush_depends(H5B2_hdr_t *hdr, unsigned depth, H5B2_node_ptr_t *node_ptrs,
+                                               unsigned start_idx, unsigned end_idx, void *old_parent,
+                                               void *new_parent);


Cherry-picked Dana's Btree const fixes

jhendersonHDF · 2022-05-03T04:46:01Z

tools/lib/h5tools.c

@@ -1843,15 +1843,21 @@ render_bin_output(FILE *stream, hid_t container, hid_t tid, void *_mem, hsize_t
                    hid_t        region_id    = H5I_INVALID_HID;
                    hid_t        region_space = H5I_INVALID_HID;
                    H5S_sel_type region_type;
+                    H5R_ref_t    tref;


Cherry-picked Dave's reference misalignment fix

bmribler · 2022-05-03T05:09:26Z

src/H5trace.c

-    H5_timer_t        function_timer      = {{0}, {0}, {0}, FALSE};
-    H5_timevals_t     function_times;
+    H5_timer_t        function_timer;
+    H5_timevals_t     function_times = {0.0, 0.0, 0.0};


Hmm, I'm confused. I thought they need to line up...

They would if you swap 123 and 124 because 123 breaks the continuous lineup.

Also, we let the formatter deal with this.

bmribler · 2022-05-03T05:15:32Z

src/H5trace.c

@@ -156,11 +160,10 @@ H5_trace(const double *returning, const char *func, const char *type, ...)
        H5_timer_init(&running_timer);


So, in some condition, the timer is initialized again? Is that ok?

H5_timer_init() just resets the timer fields.

This one tripped me up when I first read it. Note that there's a running_timer and a function_timer

* Fixes const issues in the version 2 B-trees (HDFGroup#1172) The operations that were changed are fundamentally not const since the shadow operation can modify the node structure when SWMR is in use. * Quiets const warning in H5RS code (HDFGroup#1181) * Avoid calling H5Ropen_object with a misaligned H5R_ref_t: copy the (HDFGroup#1171) * Avoid calling H5Ropen_object with a misaligned H5R_ref_t: copy the raw H5R_ref_t bytes to a heap buffer that's known to have the right alignment. * Committing clang-format changes * Use an automatic H5R_ref_t instead of malloc'ing one. Go ahead and initialize the H5R_ref_t to all-0s so that arbitrary stack content doesn't foul things up. Bail out with an error if `size` exceeds `sizeof(H5R_ref_t)`. * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Miscellaneous warnings fixes Co-authored-by: Dana Robinson <[email protected]> Co-authored-by: David Young <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Warnings fixes (#1680) * Clean stack size warnings in sio_engine (#1687) * Fixes stack size warnings in tcoords.c (#1688) * Address some warnings from casting away of const (#1684) * Fixes stack size warnings in dtransform (#1696) * Fixes stack size warnings in set_extent test (#1698) * Be a bit safer with signed arithmetic, thus quieting some signed-overflow warnings from GCC (#1706) * Avoid a signed overflow: check the range of `entry_ptr->age` before increasing it instead of increasing it and then checking the range. This quiets a GCC warning. * Avoid the potential for signed overflow by rewriting expressions `MAX(0, fwidth - n)` as `MAX(n, fwidth) - n` for various `n`. This change quiets some GCC warnings. * Change some local variables that cannot take sensible negative values from signed to unsigned. This quiets GCC warnings about potential signed overflow. * In a handful of instances, check the range of a signed integer before increasing/decreasing it, just in case the increase/decrease overflows. This quiets a handful of GCC signed-overflow warnings. * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Fix object size warnings in cache.c test (#1701) * Fix some const cast and stack/static object size warnings (#1700) * Fix various warnings * Move HDfree_const to H5private.h for wider use * Print output from all ranks in parallel tests on allocation failure * Move const pointer freeing macro to h5test.h for now * Fixes a bug where t_cache fails due to a string size being too small (#1720) * Fixes a bug where t_cache fails due to a string size being too small Recent warning reductions led to an incorrect string size being passed to h5_fileaccess, causing the test to silently fail. In addition to fixing the bug, the test will now fail noisily on setup failures. * Updates the t_cache test to fail noisily on setup errors * Fix a few Clang sanitizer warnings (#1727) * Stop lying about H5S_t const-ness (#1209) Hyperslabs can be reworked inside several H5S callbacks, making H5S_t non-const in some places where it is marked const. This change switches these incorrectly const H5S_t pointer parameters and variables to non-const where appropriate. * Fix a few warnings after recent H5S const-related changes (#1225) * Adjustments for HDF5 1.10 * Hdf5 1 12 Miscellaneous warnings fixes (#1718) * Fixes const issues in the version 2 B-trees (#1172) The operations that were changed are fundamentally not const since the shadow operation can modify the node structure when SWMR is in use. * Quiets const warning in H5RS code (#1181) * Avoid calling H5Ropen_object with a misaligned H5R_ref_t: copy the (#1171) * Avoid calling H5Ropen_object with a misaligned H5R_ref_t: copy the raw H5R_ref_t bytes to a heap buffer that's known to have the right alignment. * Committing clang-format changes * Use an automatic H5R_ref_t instead of malloc'ing one. Go ahead and initialize the H5R_ref_t to all-0s so that arbitrary stack content doesn't foul things up. Bail out with an error if `size` exceeds `sizeof(H5R_ref_t)`. * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Miscellaneous warnings fixes Co-authored-by: Dana Robinson <[email protected]> Co-authored-by: David Young <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Fix several warnings (#747) Co-authored-by: Dana Robinson <[email protected]> Co-authored-by: David Young <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

derobins and others added 3 commits May 2, 2022 23:39

Fixes const issues in the version 2 B-trees (HDFGroup#1172)

e01e1ce

The operations that were changed are fundamentally not const since the shadow operation can modify the node structure when SWMR is in use.

Quiets const warning in H5RS code (HDFGroup#1181)

2be6e9e

jhendersonHDF requested review from byrnHDF, bmribler, ChristopherHogan, gnuoyd, derobins, jrmainzer, fortnern, soumagne and vchoi-hdfgroup as code owners May 3, 2022 04:42

Miscellaneous warnings fixes

0a77ec8

jhendersonHDF force-pushed the hdf5_1_12_more_warnings_fixes branch from 9ab9d27 to 0a77ec8 Compare May 3, 2022 04:44

jhendersonHDF commented May 3, 2022

View reviewed changes

bmribler reviewed May 3, 2022

View reviewed changes

derobins approved these changes May 3, 2022

View reviewed changes

derobins merged commit 5f00066 into HDFGroup:hdf5_1_12 May 3, 2022

jhendersonHDF deleted the hdf5_1_12_more_warnings_fixes branch May 3, 2022 18:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hdf5 1 12 Miscellaneous warnings fixes #1718

Hdf5 1 12 Miscellaneous warnings fixes #1718

jhendersonHDF commented May 3, 2022 •

edited

Loading

jhendersonHDF May 3, 2022

jhendersonHDF May 3, 2022

jhendersonHDF May 3, 2022

bmribler May 3, 2022

byrnHDF May 3, 2022

derobins May 3, 2022

bmribler May 3, 2022

derobins May 3, 2022

jhendersonHDF May 3, 2022 •

edited

Loading

		@@ -156,11 +160,10 @@ H5_trace(const double returning, const char func, const char *type, ...)
		H5_timer_init(&running_timer);

Hdf5 1 12 Miscellaneous warnings fixes #1718

Hdf5 1 12 Miscellaneous warnings fixes #1718

Conversation

jhendersonHDF commented May 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jhendersonHDF May 3, 2022 • edited Loading

Choose a reason for hiding this comment

jhendersonHDF commented May 3, 2022 •

edited

Loading

jhendersonHDF May 3, 2022 •

edited

Loading