Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes Related to the Auxiliary Process #1333

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

raylu-hdf
Copy link
Contributor

@raylu-hdf raylu-hdf commented Jan 4, 2022

This PR is directly related to the PR of the changes in the utils/vfd_swmr submodule: https://github.com/HDFGroup/vfd_swmr_util/pull/1/files

The basic process is like this:

  1. The auxiliary process is enabled with the option --enable-aux-process for configure.
  2. The test script testvfdswmr.sh launches the auxiliary process with the big set test.
  3. If --enable-aux-process isn't enabled, the auxiliary process simply skips itself and exits. The big set test will run by itself.

Copy link
Collaborator

@kyang2014 kyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just browsed the code. Everything looks fine to me. The only thing I don't understand is why the github check fails. This is probably expected since I saw Vailin approve the code already.

@vchoi-hdfgroup
Copy link
Contributor

I also wondered about the github failing checks. I guess Ray will check into the failures.

@raylu-hdf
Copy link
Contributor Author

I also wondered about the github failing checks. I guess Ray will check into the failures.

The failure happened because this PR tried to check out the CMake and Makefile for the auxiliary process but couldn't. I need to ask Dana why the auxiliary process didn't show up in the submodule after I merged the other PR.

@raylu-hdf raylu-hdf merged commit 5c782f7 into HDFGroup:feature/vfd_swmr Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants