Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake build of hdf5 installs mirror_server{,_stop} when VFD is not built #4984

Closed
opoplawski opened this issue Oct 19, 2024 · 0 comments · Fixed by #5055
Closed

cmake build of hdf5 installs mirror_server{,_stop} when VFD is not built #4984

opoplawski opened this issue Oct 19, 2024 · 0 comments · Fixed by #5055
Assignees
@derobins
Labels
Component - Build CMake, Autotools Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub
Milestone
2.0.0

Comments

@opoplawski
Copy link
Contributor

Describe the bug
When doing a cmake build, the mirror_server{,_stop} utilities are installed even wihen the mirror VFD is not built. This seems to be because the former is triggered by HDF5_BUILD_UTILS which is on by default, not HDF5_BUILD_MIRROR_VFD.

Expected behavior
mirror_server and mirror_server_stop are not installed when HDF5_BUILD_MIRROR_VFD is OFF.

Platform (please complete the following information)

  • HDF5 version 1.14.5
  • Build system - cmake

Initial discussion in #4933
@bmribler bmribler added Component - Build CMake, Autotools Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub labels Oct 25, 2024
@derobins derobins added this to the 2.0.0 milestone Oct 29, 2024
@derobins derobins self-assigned this Oct 29, 2024
@lrknox lrknox mentioned this issue Nov 1, 2024
Merged
@lrknox lrknox closed this as completed in 0af437a Nov 1, 2024
brtnfld pushed a commit to brtnfld/hdf5 that referenced this issue Nov 4, 2024
@lrknox @brtnfld
Check if mirror VFD and subfiling VFD are enabled before adding their (…
1076889 
…HDFGroup#5055)

respective utils subdirectories.

Fixes HDFGroup#4984.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derobins derobins

Labels
Component - Build CMake, Autotools Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Don't add util subdirs when VFDs are not enabled lrknox/hdf5
3 participants
@derobins @opoplawski @bmribler