Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accum test fails on macOS 12 #2261

Closed
byrnHDF opened this issue Nov 16, 2022 · 4 comments · Fixed by #2999
Closed

accum test fails on macOS 12 #2261

byrnHDF opened this issue Nov 16, 2022 · 4 comments · Fixed by #2999
Assignees
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub

Comments

@byrnHDF
Copy link
Contributor

byrnHDF commented Nov 16, 2022

19: Testing simple freeing metadata accumulator PASSED
19: Testing large metadata I/O operations PASSED
19: Testing random writes to accumulator PASSED
19: Testing SWMR write of large metadata: with latest format FAILED
19: at /Users/runner/work/hdf5/hdf5/test/accum.c:2292 in test_swmr_write_big()...
19: child process exited abnormally
19: Testing SWMR write of large metadata: with non-latest-format FAILED
19: at /Users/runner/work/hdf5/hdf5/test/accum.c:2292 in test_swmr_write_big()...
19: child process exited abnormally
19: *** TESTS FAILED ***
19:
The relevant code in accum.c (function test_swmr_write_big) that triggers the error:
{
pid_t pid; /* Process ID /
int status; /
Status returned from child process */

    /* Fork child process to verify that the data at [1024, 2014] does get written to disk */
    if ((pid = HDfork()) < 0) {
        HDperror("fork");
        FAIL_STACK_ERROR;
    }
    else if (0 == pid) { /* Child process */
        /* By convention, argv[0] tells the name of program invoked.
         *
         * execv on NetBSD 8 will actually return EFAULT if there is a
         * NULL at argv[0], so we follow the convention unconditionally.
         */
        char        swmr_reader[] = SWMR_READER;
        char *const new_argv[]    = {swmr_reader, NULL};
        /* Run the reader */
        status = HDexecv(SWMR_READER, new_argv);
        HDprintf("errno from execv = %s\n", HDstrerror(errno));
        FAIL_STACK_ERROR;
    } /* end if */

    /* Parent process -- wait for the child process to complete */
    while (pid != HDwaitpid(pid, &status, 0))
        /*void*/;

    /* Check if child process terminates normally and its return value */
    if (WIFEXITED(status) && !WEXITSTATUS(status))
        process_success = TRUE;
}
@byrnHDF byrnHDF added the bug label Nov 16, 2022
@byrnHDF
Copy link
Contributor Author

byrnHDF commented Nov 16, 2022

This test passes the CI when the macOS is 11.7.1 and fails when the CI uses macOS 12.6.1

byrnHDF added a commit to byrnHDF/hdf5 that referenced this issue Nov 16, 2022
@hyoklee
Copy link
Member

hyoklee commented Nov 16, 2022

Duplicate of #1289?

lrknox pushed a commit that referenced this issue Nov 16, 2022
* Remove hard-coded version text

* Use macOS 11 until accum test is fixed see #2261
@derobins derobins removed the bug label Mar 3, 2023
@derobins derobins self-assigned this May 4, 2023
@derobins derobins changed the title [BUG] accum test fails on macOS 12 accum test fails on macOS 12 May 4, 2023
@derobins derobins added Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - Testing Code in test or testpar directories, GitHub workflows Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub labels May 4, 2023
@hyoklee
Copy link
Member

hyoklee commented May 24, 2023

@derobins can it be closed as well with your recent commit?

@derobins
Copy link
Member

Fixed in #2999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants