Flush stor #486
Merged
Flush stor #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihikodaki
requested changes
Oct 4, 2024
The flush test requires sending UDP packets to a PDU device. We will emulate this device on the host, so we need a connection between client VMs and the host. Attaching the br_world to the client is bad because a client can download updates/drivers/applications from the Internet and spend CPU/RAM resources in vain. Signed-off-by: Kostiantyn Kostiuk <[email protected]>
akihikodaki
approved these changes
Oct 5, 2024
YanVugenfirer
approved these changes
Oct 6, 2024
akihikodaki
requested changes
Oct 10, 2024
There was a problem hiding this comment.
https://oidref.com/1.3.6.1.4.1.318.1.1.12.3.3.1.1.4 says it has delayedReboot so you may check if the value is used. I don't require to do so as Microsoft's documentation does not mention it.
akihikodaki
reviewed
Oct 10, 2024
The flush test sends an SNMP request to PDU to reset the power on the hardware PC. As the flush test sends only one type of request we don't need to parse it and can just wait for any UDP packet and perform a hard reset of the VM. Signed-off-by: Kostiantyn Kostiuk <[email protected]>
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
kostyanf14
force-pushed
the
flush-stor
branch
from
2913125
to
c136f76
Compare
akihikodaki
approved these changes
Oct 12, 2024
YanVugenfirer
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.