Introduce AutoHCK::ResourceScope #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also: I'm still testing and have not confirmed its well-behaving. |
kostyanf14
reviewed
Jul 12, 2023
akihikodaki
force-pushed
the
akihikodaki/scope
branch
2 times, most recently
from
a7a3397 to
dee06ea
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
akihikodaki
force-pushed
the
akihikodaki/scope
branch
2 times, most recently
from
5480222 to
0ff4aa5
Compare
akihikodaki
force-pushed
the
akihikodaki/scope
branch
3 times, most recently
from
546fa68 to
b561ef5
Compare
|
It happened to hang with old Timeout so I fixed it with commit 1b276f3. |
akihikodaki
force-pushed
the
akihikodaki/scope
branch
from
b561ef5 to
e097bed
Compare
akihikodaki
force-pushed
the
akihikodaki/scope
branch
from
e097bed to
e3dd1fd
Compare
|
Commit 4b59a08 removed destructive methods from |
Signed-off-by: Akihiko Odaki <[email protected]>
This ensures that the file gets closed even when an error raised during file operation. Signed-off-by: Akihiko Odaki <[email protected]>
This saves lots of lines and aids following refactorings. Signed-off-by: Akihiko Odaki <[email protected]>
Before this change, studio or client was chosen according to the name parameter. However, the values of the name parameter were not defined in one place. Particularly, the name of studio machine was defined in two places, AutoHCK::HCKStudio::STUDIO and AutoHCK::QemuHCK::STUDIO. Eliminate this potential hazard by introducing specialized methods for running studio or client machines. Signed-off-by: Akihiko Odaki <[email protected]>
It is a common idiom in Ruby to perform operating system calls during object initialization to implement the Resource-Acquisition-Is-Initialization pattern and to gain its benefit. One of such an existing example is File class, which performs file open operation during initialization; that clarifies the close method must be called when an instance exists. Signed-off-by: Akihiko Odaki <[email protected]>
Managing a process from several threads can lead to race conditions; we already have some code to deal with such a race condition that can happen when a process reap is occuring. Perform all process management operations in a dedicated thread to avoid them. Signed-off-by: Akihiko Odaki <[email protected]>
akihikodaki
force-pushed
the
akihikodaki/scope
branch
from
e3dd1fd to
59d8396
Compare
kostyanf14
reviewed
Aug 1, 2023
Before this change, the management of resources that require explicit deallocations were done ad-hoc and inconsistent. This new class provides a unified mechanism for this purpose and ensures the following: - Resource deallocation happens in reverse-allocation order. This is important because an object often depend on another object allocated earlier and cannot outlive the earlier object. - Interrupts during deallocation will be postponed. (Ensured with Thread.handle_interrupt(AutoHCKInterrupt => :never)) - An interrupt won't be handled while an allocated object is assigned to a AutoHCK::ResourceScope. (Ensured with Thread.handle_interrupt(AutoHCKInterrupt => :on_blocking)) For Thread.handle_interrupt invocation, a dedicated exception class, AutoHCKInterrupt is used so that it will not interfer with other interrupts that can happen in child threads. Moreover, this class provides transaction feature that facilitates error handling during resource allocation. If an error happens in a transaction, resources assigned to the transaction scope will be safely deallocated. Otherwise, they will escape the transaction scope and be available to the outer scope. Signed-off-by: Akihiko Odaki <[email protected]>
HCK is not yet available during installation so avoid using it. Signed-off-by: Akihiko Odaki <[email protected]>
This allows to react quickly when QEMU finishes. Signed-off-by: Akihiko Odaki <[email protected]>
The test configuration step is quite a complicated; it first launches machines, and performs various configuration steps. To provide more visibility, log when machines are being launched. Signed-off-by: Akihiko Odaki <[email protected]>
The message is printed for normal exit as well so the word "aborting" is inappropriate. Signed-off-by: Akihiko Odaki <[email protected]>
akihikodaki
force-pushed
the
akihikodaki/scope
branch
from
59d8396 to
428ead6
Compare
kostyanf14
approved these changes
Aug 3, 2023
YanVugenfirer
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have already done several changes to improve the abortion logic, but I still see an error occurs during abortion. I also heard AutoHCK sometimes hangs after the tests finish, which imply some resources associated threads are left unreleased.
To eliminate this kind of errors completely, I propose
AutoHCK::ResourceScopeas a single true resource management mechanism.This pull request makes every code dealing with unmanaged resources use the new mechanism so it's huge. Take time if it's correctly used everywhere before merging.