Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default timeouts #64

Merged
merged 5 commits into from
May 16, 2023
Merged

Update default timeouts #64

merged 5 commits into from
May 16, 2023

Conversation

starbelly
Copy link
Contributor

@starbelly starbelly commented Apr 12, 2023 •
edited
Loading

  • Use and set send_timeout by to 60 seconds in socket_opts
  • change reply_timeout to 60 seconds
  • change caller timeouts to infinity

@starbelly starbelly force-pushed the bp/update-default-timeouts branch from 8176b94 to 01f912d Compare April 12, 2023 21:20
@starbelly
Update default timeouts
2c30c82 
- Use and set send_timeout by to 60 seconds in `socket_opts`
- change reply_timeout to 60 seconds
- change caller timeouts to infinity
@starbelly starbelly force-pushed the bp/update-default-timeouts branch from 16fd290 to 2c30c82 Compare April 12, 2023 21:51
@vikas15bhardwaj
Copy link
Contributor

vikas15bhardwaj commented Apr 18, 2023 •
edited
Loading

Do you think we should add these timeout details to either Client module or in README? I checked, we have reply_timeout in start_link doc, and generic socket_opts. May be we can add socket_opts send_timeout separately or some example.

@starbelly
Copy link
Contributor Author

Do you think we should add these timeout details to either Client module or in README? I checked, we have reply_timeout in start_link doc, and generic socket_opts. May be we can add socket_opts send_timeout separately or some example.

In fact, I do, I think I wanted to see how you felt about the changes first before documenting them :) Also need to add another test. ❤️

This was referenced Apr 19, 2023
Closed
Closed
vikas15bhardwaj
vikas15bhardwaj reviewed May 9, 2023
View reviewed changes
lib/mllp/client.ex Outdated Show resolved Hide resolved
vikas15bhardwaj
vikas15bhardwaj approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@vikas15bhardwaj vikas15bhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikas15bhardwaj vikas15bhardwaj merged commit 8b1721d into main May 16, 2023
@starbelly starbelly deleted the bp/update-default-timeouts branch August 4, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikas15bhardwaj vikas15bhardwaj vikas15bhardwaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@starbelly @vikas15bhardwaj