test(response): added tests to missing coverage and better organizati…

…on to test
H4ad · Apr 2, 2022 · 90d7f29 · 90d7f29
1 parent 1813ec1
commit 90d7f29
Show file tree

Hide file tree

Showing 3 changed files with 83 additions and 14 deletions.
diff --git a/src/network/response.ts b/src/network/response.ts
@@ -101,8 +101,7 @@ export class ServerlessResponse extends ServerResponse {
   }
 
   static headers(res: ServerlessResponse) {
-    const headers =
-      typeof res.getHeaders === 'function' ? res.getHeaders() : res._headers;
+    const headers = res.getHeaders();
 
     return Object.assign(headers, res[HEADERS]);
   }
@@ -136,12 +135,21 @@ export class ServerlessResponse extends ServerResponse {
       }
     }
 
-    // I use ignore here because in nodejs 12.x, statusMessage can be string | OutgoingHttpHeaders
-    // But in nodejs >=14.x, statusMessage can also be OutgoingHttpHeaders[]
-    // I take care of these cases above, but here I can't handle it well, so I give up
-    // nodejs 12.x ref: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/v12/http.d.ts#L229
-    // nodejs 14.x ref: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/v14/http.d.ts#L263
-    // @ts-ignore
+    return this.callNativeWriteHead(statusCode, statusMessage, obj);
+  }
+
+  /**
+   * I use ignore here because in nodejs 12.x, statusMessage can be string | OutgoingHttpHeaders
+   * But in nodejs >=14.x, statusMessage can also be OutgoingHttpHeaders[]
+   * I take care of these cases above, but here I can't handle it well, so I give up
+   * nodejs 12.x ref: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/v12/http.d.ts#L229
+   * nodejs 14.x ref: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/v14/http.d.ts#L263
+   */
+  protected callNativeWriteHead(
+    statusCode: number,
+    statusMessage?: string | any | any[],
+    obj?: any | any[],
+  ): this {
     return super.writeHead(statusCode, statusMessage, obj);
   }
 }
diff --git a/test/handlers/default.handler.spec.ts b/test/handlers/default.handler.spec.ts
@@ -116,4 +116,33 @@ describe('DefaultHandler', () => {
       Buffer.from(JSON.stringify(response)).toString('base64'),
     );
   });
+
+  it('should forward and return the response from a request with empty body', async () => {
+    const framework = new FrameworkMock(200, response);
+
+    const handler = defaultHandler.getHandler(
+      app,
+      framework,
+      adapters,
+      resolver,
+      { isBinary: () => true },
+      respondWithErrors,
+      logger,
+    );
+
+    const event = createApiGatewayV2('GET', '/users', undefined, {
+      test: 'true',
+    });
+    const context = { test: Symbol('unique') };
+
+    const result = await handler(event, context, NO_OP);
+
+    expect(result).toHaveProperty('headers', {});
+    expect(result).toHaveProperty('isBase64Encoded', true);
+    expect(result).toHaveProperty('statusCode', 200);
+    expect(result).toHaveProperty(
+      'body',
+      Buffer.from(JSON.stringify(response)).toString('base64'),
+    );
+  });
 });
diff --git a/test/network/response.spec.ts b/test/network/response.spec.ts
@@ -183,23 +183,41 @@ describe('ServerlessResponse', () => {
   });
 
   it('should write headers correctly in object when call writeHead', () => {
-    const response = new ServerlessResponse({
+    class MockServerlessResponse extends ServerlessResponse {
+      public callNativeWriteHead(
+        statusCode: number,
+        statusMessage?: string | any | any[],
+        obj?: any | any[],
+      ): this {
+        return super.callNativeWriteHead(statusCode, statusMessage, obj);
+      }
+    }
+
+    const response = new MockServerlessResponse({
       method: 'GET',
     });
 
+    response.callNativeWriteHead = jest.fn();
     response.setHeader = jest.fn();
 
-    expect(() => response.writeHead(200, { test: 'true' })).not.toThrowError();
+    expect(() => response.writeHead(200, { test1: 'true' })).not.toThrowError();
     expect(() =>
-      response.writeHead(200, 'test', { test: 'true' }),
+      response.writeHead(200, [{ test2: 'true' }, { test3: 'true' }]),
+    ).not.toThrowError();
+    expect(() =>
+      response.writeHead(200, 'test', { test4: 'true' }),
     ).not.toThrowError();
 
     // eslint-disable-next-line @typescript-eslint/unbound-method
-    expect(response.setHeader).toHaveBeenCalledTimes(2);
+    expect(response.setHeader).toHaveBeenCalledTimes(4);
+    // eslint-disable-next-line @typescript-eslint/unbound-method
+    expect(response.setHeader).toHaveBeenNthCalledWith(1, 'test1', 'true');
+    // eslint-disable-next-line @typescript-eslint/unbound-method
+    expect(response.setHeader).toHaveBeenNthCalledWith(2, 'test2', 'true');
     // eslint-disable-next-line @typescript-eslint/unbound-method
-    expect(response.setHeader).toHaveBeenNthCalledWith(1, 'test', 'true');
+    expect(response.setHeader).toHaveBeenNthCalledWith(3, 'test3', 'true');
     // eslint-disable-next-line @typescript-eslint/unbound-method
-    expect(response.setHeader).toHaveBeenNthCalledWith(2, 'test', 'true');
+    expect(response.setHeader).toHaveBeenNthCalledWith(4, 'test4', 'true');
   });
 
   it('should write headers correctly in object when call setHeader', () => {
@@ -218,4 +236,18 @@ describe('ServerlessResponse', () => {
     expect(response.getHeaders()).not.toHaveProperty('test2', 'value');
     expect(response.headers).toHaveProperty('test2', 'value');
   });
+
+  it('should received error when statusCode is falsy', () => {
+    const request = new ServerlessRequest({
+      method: 'GET',
+      url: '/users',
+      headers: {},
+    });
+
+    request.statusCode = undefined;
+
+    expect(() => ServerlessResponse.from(request)).toThrowError(
+      'Invalid status code',
+    );
+  });
 });