Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FemaleHandsOptionsColorsFix #266

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

TheScarFr
Copy link
Contributor

@TheScarFr TheScarFr commented Nov 2, 2024

Fix the Female avatar's Hands Options colors switch when selecting a different Hands Option:

The fix constist to put the Nails color in the layer 1 and to put the Gloves color in the layer 2,
for both the Fingerless Gloves and the Canvas Gloves.
It have been done in the "sources\avatar\clothing\bas.avatar.female.max" file with "3DS Max 2022", and then the "compiled\dat\GlobalClothing_District_Female.prp" file have been exported from the MAX file.

Fix the Female avatar's Hands Options colors switch when selecting a different Hands Option
@Hoikas
Copy link
Member

Hoikas commented Nov 3, 2024

Fix the Female avatar's Hands Options colors switch when selecting a different Hands Option:

I'm not sure I understand what you're trying to fix based on this description.

@Hoikas Hoikas added the awaiting author This pull request or issue is blocked on a response or revision from the author. label Nov 3, 2024
@dpogue
Copy link
Member

dpogue commented Nov 3, 2024

I'm not sure I understand what you're trying to fix based on this description.

If you set a fingernail colour for a female avatar, and then put gloves on, and then remove them, it loses the nail colour due to different clothing items using different tint layers for the nails rather than being consistent. The fix is to consistently use the same tint field for the nails

@Hoikas Hoikas added technical An issue or fix that is primarily technical objective An issue or fix that is a clear defect or improvement and removed awaiting author This pull request or issue is blocked on a response or revision from the author. labels Nov 3, 2024
@EhrenCG
Copy link
Contributor

EhrenCG commented Nov 3, 2024

Dang it, you explained before I could dpogue lol, but I did create this image of the effect of how the color swaps when you just swap the item by using a red and cyanish color here:

I still like visual representations in general so I'm still posting it. (This is obviously without the fix.)

MovingNailColor

Copy link
Member

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Hoikas Hoikas merged commit 4461c11 into H-uru:master Nov 3, 2024
1 check passed
@TheScarFr TheScarFr deleted the FemaleHandsOptionsColorsFix branch November 3, 2024 07:22
@TheScarFr TheScarFr restored the FemaleHandsOptionsColorsFix branch November 3, 2024 16:48
@TheScarFr
Copy link
Contributor Author

[update] Wardrobe: Fix for the Female Hands Options colors. {TheScar(.fr)}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
objective An issue or fix that is a clear defect or improvement technical An issue or fix that is primarily technical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants