Remove xLinkingBookDefs import from psnlYeeshaPageChanges.py #1664
Conversation
There was a problem hiding this comment.
I'm not really sure why we want to remove the xLinkingBookDefs import. But, we could probably salvage the log message with something like this:
# Top of file
import itertools
# Here:
PtDebugPrint("psnlYeeshaPageChanges: You've found the following Yeesha Pages:")
for thispage in itertools.count(1):
varName = f"YeeshaPage{thispage}"
if FoundValue := ageSDL.findVar(varName):
PtDebugPrint(f"\t The previous value of the SDL variable '{varName}' is {FoundValue.getInt()}")
if FoundValue.getInt() != 0:
PtDebugPrint(f"psnlYeeshaPageChanges: You have found Yeesha Page #{thispage}')
else:
# The first not found page variable is the end of the list of Yeesha Pages.
breakAlthough, tbh, this should probably be in somewhere like Personal.py so we don't have to have the obnoxious guard hack.
Moved it to Personal.py instead
|
|
Did the snippet I post not work? What you've submitted still imports |
Hazado
force-pushed
the
PruneComment
branch
2 times, most recently
from
e6e2f60 to
898bad3
Compare
Co-authored-by: Adam Johnson <[email protected]>
All the comments was doing here was list all the Relto pages you had if you had not gotten the 5th page
Removing that section allows removing the xLinkingBookDefs import