Remove last uses of hsStrcpy and hsStrncpy
#1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoikas
reviewed
Jan 27, 2025
dgelessus
force-pushed
the
remove_hsstrcpy
branch
from
ed55330 to
2274800
Compare
Hoikas
approved these changes
Jan 27, 2025
dpogue
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most calls to these functions have already been removed in previous
ST::string/Unicode conversion work. This PR takes care of the last few remaining uses and finally drops these custom functions (in favor ofST::stringand standard C APIs).Important difference:
hsStrncpyalways ensured that the destination string is 0-terminated, whereas the standard Cstrncpywill not add a 0 terminator if the destination buffer is too small to hold the entire source string. So we do lose this convenience/safety feature by switching to standard functions. But considering that (after this PR) the codebase only contains 12strncpycalls in total, I don't thinkhsStrncpyis worth keeping around (especially not in the HeadSpin.h header that's included almost everywhere).