ENH Faster method for creating injected instances (silverstripe#10265)

src/Core/Injector/InjectionCreator.php

@@ -2,29 +2,18 @@
 
 namespace SilverStripe\Core\Injector;
 
-use ReflectionClass;
-use ReflectionException;
-
 /**
  * A class for creating new objects by the injector.
  */
 class InjectionCreator implements Factory
 {
-
     public function create($class, array $params = [])
     {
-        try {
-            $reflector = new ReflectionClass($class);
-        } catch (ReflectionException $e) {
-            throw new InjectorNotFoundException($e);
+        if (!class_exists($class)) {
+            throw new InjectorNotFoundException("Class {$class} does not exist");
         }
-
-        if (count($params)) {
-            // Remove named keys to ensure that PHP7 and PHP8 interpret these the same way
-            $params = array_values($params);
-            return $reflector->newInstanceArgs($params);
-        }
-
-        return $reflector->newInstance();
+        // Ensure there are no string keys as they cannot be unpacked with the `...` operator
+        $values = array_values($params);
+        return new $class(...$values);
     }
 }